Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operationAsString Export #1309

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Aug 9, 2022

The operationAsString function is used in the ADIOS1 backend, which does symbol hiding to wrap ADIOS1's MPI mock library. Thus, we need to export this symbol once we wrap ADIOS1.

Fix #1308

The `operationAsString` function is used in the ADIOS1 backend, which
does symbol hiding to wrap ADIOS1's MPI mock library. Thus, we need
to export this symbol once we wrap ADIOS1.
@ax3l
Copy link
Member Author

ax3l commented Aug 9, 2022

Interesting, had a flake in Tooling / Clang ASAN USBSAN:

number of particle species: 0
[AbstractIOHandlerImpl] IO Task OPEN_FILE failed with exception. Removing task from IO queue and passing on the exception.

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
SerialIOTests is a Catch v2.13.9 host application.
Run with -? for options

-------------------------------------------------------------------------------
append_mode
-------------------------------------------------------------------------------
/home/runner/work/openPMD-api/openPMD-api/test/SerialIOTest.cpp:6108
...............................................................................

/home/runner/work/openPMD-api/openPMD-api/test/SerialIOTest.cpp:6108: FAILED:
  {Unknown expression after the reported line}
due to unexpected exception with message:
  ERROR: attribute /date has been defined and its value cannot be changed, in
  call to DefineAttribute

will restart.

@franzpoeschel
Copy link
Contributor

Interesting, had a flake in Tooling / Clang ASAN USBSAN:

number of particle species: 0
[AbstractIOHandlerImpl] IO Task OPEN_FILE failed with exception. Removing task from IO queue and passing on the exception.

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
SerialIOTests is a Catch v2.13.9 host application.
Run with -? for options

-------------------------------------------------------------------------------
append_mode
-------------------------------------------------------------------------------
/home/runner/work/openPMD-api/openPMD-api/test/SerialIOTest.cpp:6108
...............................................................................

/home/runner/work/openPMD-api/openPMD-api/test/SerialIOTest.cpp:6108: FAILED:
  {Unknown expression after the reported line}
due to unexpected exception with message:
  ERROR: attribute /date has been defined and its value cannot be changed, in
  call to DefineAttribute

will restart.

This is a bug on dev in combination with ADIOS2 v2.7, #1302 will fix it

@franzpoeschel franzpoeschel merged commit 34e7df6 into openPMD:dev Aug 15, 2022
@ax3l ax3l deleted the fix-operationAsString-export branch September 29, 2022 20:51
eschnett added a commit to eschnett/openPMD-api that referenced this pull request Nov 11, 2022
* dev: (70 commits)
  Docs: Recommend Static Build for Superbuilds (openPMD#1325)
  Python 3.11 (openPMD#1323)
  pybind11: v2.10.1+ (openPMD#1322)
  Add Attribute::getOptional<T>() and use to add some more dynamic datatype conversions at read time (openPMD#1278)
  Mapping between ADIOS steps and openPMD iterations (openPMD#949)
  Deprecate shareRaw (openPMD#1229)
  Fix append mode double attributes (openPMD#1302)
  Constant scalars: Don't flush double (openPMD#1315)
  Remove caching cmake vars (openPMD#1313)
  [pre-commit.ci] pre-commit autoupdate (openPMD#1311)
  storeChunk: Add an overload for shared_ptr<T[]> (openPMD#1296)
  Fix `operationAsString` Export (openPMD#1309)
  ADIOS2: more fine-grained control for file endings (openPMD#1218)
  [pre-commit.ci] pre-commit autoupdate (openPMD#1307)
  Fix file existence check in parallel tests (openPMD#1303)
  ADIOS2: Flush to disk within a step (openPMD#1207)
  [pre-commit.ci] pre-commit autoupdate (openPMD#1304)
  [pre-commit.ci] pre-commit autoupdate (openPMD#1295)
  Update catch2 to v2.13.9 (openPMD#1299)
  [pre-commit.ci] pre-commit autoupdate (openPMD#1292)
  ...

# Conflicts:
#	.github/workflows/linux.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.14.5: ADIOS1 Link Error on macOS
2 participants