Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update examples #1371

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Update examples #1371

merged 3 commits into from
Feb 22, 2023

Conversation

franzpoeschel
Copy link
Contributor

@franzpoeschel franzpoeschel commented Feb 10, 2023 •
edited
Loading

  • Use Series::close
  • Use Iteration::close
  • Use Series::readIterations and Series::writeIterations

Some storeChunk updates are still to come, but they need #1294 and I will probably just push a further commit to that PR with them.

Also fix two bugs noticed when changing the examples.

TODO:

@franzpoeschel franzpoeschel added this to the 0.15.0 milestone Feb 10, 2023
@franzpoeschel franzpoeschel requested a review from ax3l February 10, 2023 14:48
@franzpoeschel franzpoeschel force-pushed the update-examples-linear-read branch from ed8fab0 to 5e2ba3a Compare February 10, 2023 15:12
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 10, 2023
View reviewed changes
src/ReadIterations.cpp Outdated
ReadIterations::ReadIterations(Series series) : m_series(std::move(series))
{}
ReadIterations::ReadIterations(
Series series,

Check notice

Code scanning / CodeQL

Large object passed by value

This parameter of type [Series](1) is 80 bytes - consider passing a const pointer/reference instead.
@ax3l ax3l self-assigned this Feb 10, 2023
@ax3l ax3l added the tests label Feb 10, 2023
@franzpoeschel
Update examples
9adeaa8 
Mainly Series::close, Iteration::close, Series::writeIterations,
Series::readIterations, READ_LINEAR
@franzpoeschel
Fix: Python bindings use copy return value policies
54c462f
@franzpoeschel
Fix: Use explicit ::close() call in WriteIterations
b9ce527
@franzpoeschel franzpoeschel force-pushed the update-examples-linear-read branch from 5e2ba3a to b9ce527 Compare February 20, 2023 14:09
@ax3l
Copy link
Member

ax3l commented Feb 22, 2023

Thanks a lot!

As a follow-up, let's not forget these three:

@ax3l ax3l merged commit f883f8e into openPMD:dev Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels
affects latest release bug documentation frontend: Python3 tests
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@franzpoeschel @ax3l