Fix unique_ptr<T, Del>
constructor of UniquePtrWithLambda
#1552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot adding tests for that constructor and it turns out it is broken. It's the most generic conversion constructor that the class has (there is a specialization for
std::unique_ptr<T>
), so this is not used very often. There are two problems:get_deleter()
twice. This PR removes the second invocation.std::function
needs a copyable lambda, butDel
might be non-copyable. Add a custom path for that case.This PR adds two tests for each case. Without this PRs, the compile time errors are as follows:
1:
2: