Pullreq #16
Closed
Pullreq #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(back from vacation) I cherry-picked #2d39d08 already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Michael,
I have two pull requests: the first one is the preliminary solver_describe_decisions() fixed I emailed you about. I am still unsure about the right thing to do there. With the fix everything works as expected on my side so far (no heavy testing took place though), but perhaps I'd be better off without the patch and changing hawkey to treat SOLVER_REASON_UNIT_RULE just like SOLVER_REASON_RESOLVE_JOB and.
The second patch is a fix to a build problem that has appeared recently in Fedora with C boolean types. I hope there's no concrete reason not to use stdbool.h from solv.i.
Thank you, Ales