Various Portability Improvements #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* There were identical SYSTEM_LIBRARIES definitions in several CMakeLists.txt files (well almost identical -- some still checked for DEBIAN instead of ENABLE_RPMDB). Now it's defined in the main CMakeLists.txt. * Remove --as-needed from CMAKE_C_FLAGS and add it to SYSTEM_LIBRARIES. It isn't a compiler flag and older gcc's issue a warning when encountering it on a compile line.
Make sure variables are declared at the beginning of a block.
futimens() is POSIX, futimes() isn't.
mlschroe
added a commit
that referenced
this pull request
Apr 2, 2013
Various Portability Improvements
A few headers already included 'export "C"' blocks, also wrapping other #include's. This patch cleanly wraps the contents of all public headers instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few patches in preparation of my (not quite ready yet) Haiku port of libsolv. The changes aren't Haiku specific, but general portability improvements, like making header C++ safe, C89 fixes, a POSIX fix, etc.