Add a couple of architectures. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Fedora rel-eng team missed ia32e, amd64, athlon, geode, ppc64iseries and ppc64pseries.
mlschroe
added a commit
that referenced
this pull request
May 2, 2014
Add a couple of architectures.
| "i586", "i586:i486:i386", | ||
| "i486", "i486:i386", | ||
| "i386", "i386", | ||
| "s390x", "s390x:s390", | ||
| "s390", "s390", | ||
| "ia64", "ia64:i686:i586:i486:i386", | ||
| "ppc64iseries", "ppc64iseries:ppc64:ppc", | ||
| "ppc64pseries", "ppc64pseries:ppc64:ppc", |
There was a problem hiding this comment.
just small note, that this breaks indentation, so it would be nice to have again all architectures properly aligned ( there is nice vim plugin Align for such task.
There was a problem hiding this comment.
Good point, though we agreed with @mlschroe that we shouldn't go for reformatting this time so we don't complicate the git blame output.
There was a problem hiding this comment.
yes, if people do not use git blame -w it mess blaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Michael, this is about https://bugzilla.redhat.com/show_bug.cgi?id=1049209
The rel-eng says they need it (though I'm doubtful, they're all obsolete) If you'd really hate to merge these I'll find some other way to deal with the bug.
I smoke tested the stack but don't have the opportunity and resources to test the new specific architectures.