Fix progress bar code to support progressbar2 #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottp-dpaw
force-pushed
the
progress_fix
branch
from
53ad18c to
b45f874
Compare
|
I was slightly confused when I saw the patch for the first time because progressbar has version 2.x and progressbar2 has version 4.x :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The progress bar code in
meter.PBTextMetertouches some third-party class state to hide the bar after the job is completed. This works fine for the unmaintained 2018 progressbar library (https://pypi.org/project/progressbar/), however is not compatible with the later progressbar2 fork (https://pypi.org/project/progressbar2/) and causes a crash.