Merge pull request #179 from okurz/feature/no_aggregate_log

Use better log message for 'missing aggregate results'
openSUSE · May 8, 2024 · 12ceaa1 · 12ceaa1
2 parents 13f1e14 + 975513f
commit 12ceaa1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/openqabot/approver.py b/openqabot/approver.py
@@ -106,7 +106,7 @@ def _approvable(self, inc: IncReq) -> bool:
             log.info(e)
 
             if any(i.withAggregate for i in i_jobs):
-                log.info("Aggregate missing for %s", _mi2str(inc))
+                log.info("No aggregate test results found for %s", _mi2str(inc))
                 return False
 
             u_jobs = []

diff --git a/tests/test_approve.py b/tests/test_approve.py
@@ -294,9 +294,9 @@ def test_inc_passed_aggr_without_results(fake_qem, fake_two_passed_jobs, caplog)
     assert len(caplog.records) >= 1, "we rely on log messages in tests"
     messages = [x[-1] for x in caplog.record_tuples]
     assert "Start approving incidents in IBS" in messages
-    assert "Aggregate missing for SUSE:Maintenance:1:100" in messages
-    assert "Aggregate missing for SUSE:Maintenance:2:200" in messages
-    assert "Aggregate missing for SUSE:Maintenance:3:300" in messages
+    assert "No aggregate test results found for SUSE:Maintenance:1:100" in messages
+    assert "No aggregate test results found for SUSE:Maintenance:2:200" in messages
+    assert "No aggregate test results found for SUSE:Maintenance:3:300" in messages
     assert "Incidents to approve:" in messages
     assert "* SUSE:Maintenance:4:400" in messages
     assert "End of bot run" in messages