approver: Extract function 'was_older_job_ok' #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
force-pushed
the
feature/extract_for_loop
branch
from
f4399e1 to
0f9389e
Compare
okurz
force-pushed
the
feature/extract_for_loop
branch
from
0f9389e to
f6eab34
Compare
Martchus
requested changes
May 8, 2024
There was a problem hiding this comment.
Doesn't this break the cases where the loop previously logged an info message (like "Cannot ignore aggregate failure %s for update %s because: Older passing jobs do not have update under test") and then returned False? It would now continue iterating and log "Cannot ignore aggregate failure %s for update %s because: Older usable jobs did not succeed. Run out of jobs to evaluate." in addition to the actually relevant log message. I guess my two inline-comment suggestions would make it behave correctly (or at last as before).
okurz
force-pushed
the
feature/extract_for_loop
branch
from
af3f9ea to
5d5c1fe
Compare
Martchus
approved these changes
May 8, 2024
|
Obsoleted by #181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my suggestion how to prevent the style issue about too many return statements encountered in