Prevent possible exceptions on salt.utils.user.get_group_dict (bsc#1212794) #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for the user having improper duplicate group
Co-authored-by: Pedro Algarvio <[email protected]>
vzhestkov
deleted the
openSUSE/fix/prevent-key-error-salt.utils.user.get_group_dict
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Backport of saltstack/salt#64599
In case if the client system has NIS enabled it could cause KeyError exception on starting the salt-minion service due to the duplicated record in the
groups:+:::, which is actually the duplicate ofrootgroup as missing gid is treated as0.What issues does this PR fix or reference?
Fixes: https://github.com/SUSE/spacewalk/issues/21917
Previous Behavior
Tracebacks on salt-minion start and no service running
New Behavior
Normal behavior
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.