Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New text games group and two text-based games #671

Closed
wants to merge 3 commits into from

Conversation

m-k-l-s
Copy link

@m-k-l-s m-k-l-s commented Jul 29, 2017

Hello, I added a group for text-based games (interactive fiction) and two sample text games, Saving John and Machine of Death.

These two sample games are available in the pyfiction library that supports different games which I plan to add to gym once some basic problems are resolved.

My questions are:

  1. How to handle variable action space and unbounded observation space? See the pull request code for my approach (always checking for the dynamic environment action space). Is this approach valid?

  2. Is it necessary that all environments support Python 2.7? The pyfiction games, for example, are only tested in Python 3.5 and 3.6.

Thank you :)

@pzhokhov
Copy link
Collaborator

pzhokhov commented Mar 7, 2019

Hi @MikulasZelinka ! Currently, our policy is not to accept new environments to gym; if still interested, I would recommend creating a separate/project. From our side, we can put a reference to it into the environments.md file. As such, closing this PR.
To your questions - the problem with handling variable / unbounded action and observation spaces is really less about how to handle them from the environment side; but how to make standard RL agents know about / work with the variable spaces. The reasonable and simple enough approach for action space is to simply set number of actions to maximum possible number of actions in the game; and if the agent outputs action that is currently invalid, terminate the episode with large negative reward. Unbounded observation space - that depends; from the PR I just see that the observation is the simulator state. How does that state look like? In principle, Box observation space supports infinite limits; moreover, an observation space can be multidiscrete with number of subspaces equal to number of bytes in simulator state, and number of choices for each 256 ( this way any state of finite-size memory can be represented).

@pzhokhov pzhokhov closed this Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants