build: switch to tsup #1103
Closed
build: switch to tsup #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ce9d6a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
force-pushed
the
main
branch
5 times, most recently
from
c94653a to
ae7a4f3
Compare
|
Any thoughts on this? This problem currently prevents usage in a CJS project. |
3 tasks
|
Since #1176 merged, we’ll try that to see if that fixes the issue. Though I’m still keeping tsup in mind in case a problem crops up with the esbuild bundle / packaging. In general, though, I am partial to simpler solutions because they are easy to tweak/debug if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Switch to tsup, and publish both cjs and esm files for
openapi-fetch.This fixes #1102
How to Review
Validate locally that the build output still works.
Checklist
examples/directory updated (if applicable)