Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct typo in "Multiple schemas" example and add tip for bund… #1528

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

melissag
Copy link

@melissag melissag commented Feb 1, 2024

…ling schemas

Changes

What does this PR change? Link to any related issue(s).
As discussed in #1497; the docs as-written give the impression that multiple schemas can be merged into a single file, as opposed to preserving 1:1 input:output. Fixed the typo, and added the suggested tip linking to Redoly's bundling documentation.

openapi-typescript_docs-update

How to Review

How can a reviewer review your changes? What should be kept in mind for this review?

Checklist

  • Unit tests updated N/A
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript) N/A

Copy link

changeset-bot bot commented Feb 1, 2024

⚠️ No Changeset found

Latest commit: 5153bcf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Great fix, thank you!

@drwpow drwpow merged commit c5c4a88 into openapi-ts:main Feb 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants