autotune export to microsoft excel #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial version, requires xlsxwriter
scottleibrand
approved these changes
Jan 2, 2017
| @@ -75,7 +83,7 @@ esac | |||
| done | |||
|
|
|||
| if [[ -z "$DIR" || -z "$NIGHTSCOUT_HOST" ]]; then | |||
| echo "Usage: oref0-autotune-test.sh <--dir=openaps_directory> <--ns-host=https://mynightscout.azurewebsites.net> [--start-date=YYYY-MM-DD] [--runs=number_of_runs] [--end-date=YYYY-MM-DD]" | |||
| echo "Usage: oref0-autotune-test.sh <--dir=openaps_directory> <--ns-host=https://mynightscout.azurewebsites.net> [--start-date=YYYY-MM-DD] [--end-date=YYYY-MM-DD] [--runs=number_of_runs] [--xls=autotune.xlsx]" | |||
There was a problem hiding this comment.
Should we have people use the --xlsx form for consistency with the expected file extension?
|
|
||
| if ! [[ -z "$EXPORT_EXCEL" ]]; then | ||
| echo Exporting to $EXPORT_EXCEL | ||
| oref0_autotune_export_to_xls --dir $DIR/autotune --output $EXPORT_EXCEL |
There was a problem hiding this comment.
Should this be named xlsx?
| @@ -32,6 +32,8 @@ | |||
| "ns-upload": "./bin/ns-upload.sh", | |||
| "ns-upload-entries": "./bin/ns-upload-entries.sh", | |||
| "oref0": "./bin/oref0.sh", | |||
| "oref0-autotune-test": "./bin/oref0-autotune-test.sh", | |||
| "oref0_autotune_export_to_xls": "./bin/oref0_autotune_export_to_xls.py", | |||
There was a problem hiding this comment.
Should this be xlsx ?
swap run and date column, do some formatting (font size, etc)
|
fixed all the review comments from @scottleibrand |
|
i think it's ready to be merged to dev |
| @@ -32,6 +32,8 @@ | |||
| "ns-upload": "./bin/ns-upload.sh", | |||
| "ns-upload-entries": "./bin/ns-upload-entries.sh", | |||
| "oref0": "./bin/oref0.sh", | |||
| "oref0-autotune-test": "./bin/oref0-autotune-test.sh", | |||
There was a problem hiding this comment.
I'm renaming and adding this as oref0-ns-autotune in my autotune-install branch. Want to just leave this off of yours, and I'll get it on mine, to avoid merge conflicts?
There was a problem hiding this comment.
Nevermind, I fixed the conflict and merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initial version, requires xlsxwriter