This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Support for FailMasterPromotionOnLagMinutes #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the mention @shlomi-noach! I will be testing it out! |
|
Behavior of this change is now validated via the (new) system tests framework: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83
Scenario:
M -> Rtopology was running with replicaRbroken for a few hours without anyone noticing. Then, masterMfails.Curent behavior:
orchestratorpromotesR. But by this we lose:Rbut not executed (e.g. because of some SQL error), orM.New config variable
FailMasterPromotionOnLagMinutestellsorchestratorto fail a promotion if, at the time a candidate replica is chosen, it is determined to be lagging too much ( >=FailMasterPromotionOnLagMinutes).cc @sougou @mcrauwel