Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Fix filter match logic, be strict about IP addresses #1318

Merged
merged 4 commits into from
Mar 7, 2021
Merged

Fix filter match logic, be strict about IP addresses #1318

merged 4 commits into from
Mar 7, 2021

Conversation

shlomi-noach
Copy link
Collaborator

@shlomi-noach shlomi-noach commented Mar 4, 2021 •
edited
Loading

Fixes #1316

Description

This PR normalizes all hostname filters matching logic, as follows:

  • filter can be an IP address, in which case it must exactly match instance hostname
  • or it can be any other value, in which case it is treated as a regexp.

This applies to:

  • DiscoveryIgnoreHostnameFilters
  • DiscoveryIgnoreMasterHostnameFilters
  • DiscoveryIgnoreReplicaHostnameFilters
  • OSCIgnoreHostnameFilters
  • ProblemIgnoreHostnameFilters
  • PromotionIgnoreHostnameFilters

@shlomi-noach shlomi-noach mentioned this pull request Mar 4, 2021
Closed
@shlomi-noach shlomi-noach merged commit c9215e7 into master Mar 7, 2021
@shlomi-noach shlomi-noach deleted the ignore-hostame-ip-regexp branch March 7, 2021 08:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

topology_recovery: Failure: no replica promoted
1 participant
@shlomi-noach