You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work in progress to be able to audit and fix KV pair inconsistency, especially external KV pair store inconsistencies.
e.g. if upon failover Consul is unavailable, orchestrator could run a consistency check against its local KV store to detect and resolve such inconsistency.
Initial commit: writing Nano timestamp in all KV stores.
Assuming ConsulCrossDataCenterDistribution is set, when the orchestrator leader distributes master KV values, we run a thorough check on all known Consul datacenters to verify all KVs exist on all these clusters and are correct. This only happens on the orchestrator leader node.
There's caching to avoid abusing consul. On first iteration as leader, orchestrator will query all KV on all consul clusters. From there on, it will rely on caching of last-known value.
What this effectively does: if a consul cluster was down for any reason, and if some failover took place at that time, and as result orcehstartor could not update that cluster with the new KV data -- the change is not lost. Every minute, orchestrator will retry updating the cluster with the most up-to-date KV data.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress to be able to audit and fix KV pair inconsistency, especially external KV pair store inconsistencies.
e.g. if upon failover Consul is unavailable,
orchestrator
could run a consistency check against its local KV store to detect and resolve such inconsistency.Initial commit: writing Nano timestamp in all KV stores.