Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Directories] #3511

Merged
merged 4 commits into from
Jan 29, 2025
Merged

[Directories] #3511

merged 4 commits into from
Jan 29, 2025

Conversation

jbleyel
Copy link
Contributor

@jbleyel jbleyel commented Jan 28, 2025

  • use different skinResolveList for xml files to support old skins

@jbleyel
[Directories]
a52f667 
* use different skinResolveList for xml files to support old skins
@jbleyel jbleyel requested a review from IanSav January 28, 2025 19:35
IanSav
IanSav approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@IanSav IanSav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a simple and logical fix to address legacy skin feature from the past and into the future.

@jbleyel
Revert "[Skin]"
677a72d 
This reverts commit 847679a.
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jbleyel jbleyel merged commit b2b47c8 into master Jan 29, 2025
4 checks passed
@jbleyel jbleyel deleted the Directories branch January 29, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanSav IanSav IanSav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbleyel @IanSav