Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

Commit

Permalink
wdt-on-panic: remove overrides from meta-phosphor
Browse files Browse the repository at this point in the history
If these are needed, they really should be done within the meta-aspeed
layer. This was originally done to allow the BMC hardware watchdogs
to control the reboot of the BMC in error scenarios vs. the kernel auto
rebooting itself. This is causing issues on AST2600 hardware because the
watchdogs are not setup correctly. Kernel panics result in the BMC
becoming unusable and not rebooting, requiring a manual power cycle.

The goal with letting the hardware watchdogs control the reboot was that
fancy things like flash side switches could be performed for recovery
scenarios. However the end to end software stack for this was never fully
implemented so if a flash side switch did occur, there would be no
notice to the user of the system, and in most cases the BMC was still
inoperable because the network settings were missing.

For now, we should just go back to the defaults built into the
meta-aspeed layer which is to panic on oops and have the kernel
immediately reboot the BMC when a panic occurs.

Once we iron out the watchdog usage, we can look into changing these
back in the meta-aspeed layer if needed.

Change-Id: I133f4050240dfb693272769f57f56974048d4acd
Signed-off-by: Andrew Geissler <[email protected]>
  • Loading branch information
geissonator authored and bradbishop committed Oct 22, 2020
1 parent 199329a commit 7777a8e
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 6 deletions.

This file was deleted.

This file was deleted.

2 changes: 0 additions & 2 deletions aspeed-layer/recipes-kernel/linux/linux-aspeed_%.bbappend
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ SRC_URI += "file://phosphor-gpio-keys.scc"
SRC_URI += "file://phosphor-gpio-keys.cfg"
SRC_URI += "file://phosphor-vlan.scc"
SRC_URI += "file://phosphor-vlan.cfg"
SRC_URI += "file://phosphor-wdt-on-panic.scc"
SRC_URI += "file://phosphor-wdt-on-panic.cfg"

KERNEL_FEATURES_append = " phosphor-vlan"
KERNEL_FEATURES_remove_qemuall = " phosphor-vlan"
Expand Down

0 comments on commit 7777a8e

Please sign in to comment.