Remove btm spacer, fix scroll bars in modals (#1053)

Since we decided that our modals should be
scrollable, some of them always have a
scrollbar showing, due to an absolutely
positioned white box at the very bottom of
the modal. I am not sure what the original
purpose of this "btm-spacer" component
was supposed to be, but it seems superfluous
to me and so I am removing it. This should stop
the scrollbars from appearing unnecessarily.

src/components/configuration/partials/wizard/ThemeDetails.tsx

@@ -121,8 +121,6 @@ const ThemeDetails = ({
 							createTranslationString={"SUBMIT"}
 							cancelTranslationString={"CANCEL"}
 						/>
-
-						<div className="btm-spacer" />
 					</div>
 				)}
 			</Formik>

src/components/events/partials/ModalTabsAndPages/DetailsMetadataTab.tsx

@@ -157,7 +157,6 @@ const DetailsMetadataTab = ({
 												isLast
 											/>
 
-													<div className="btm-spacer" />
 												</>
 											)}
 										</div>

src/components/events/partials/ModalTabsAndPages/EditScheduledEventsEditPage.tsx

@@ -427,8 +427,6 @@ const EditScheduledEventsEditPage = <T extends RequiredFormProps>({
 					}
 				}
 			/>
-
-			<div className="btm-spacer" />
 		</>
 	);
 };

src/components/events/partials/ModalTabsAndPages/EditScheduledEventsGeneralPage.tsx

@@ -142,8 +142,6 @@ const EditScheduledEventsGeneralPage = <T extends RequiredFormProps>({
 				}
 				isFirst
 			/>
-
-			<div className="btm-spacer" />
 		</>
 	);
 };

src/components/events/partials/ModalTabsAndPages/EventDetailsSchedulingTab.tsx

@@ -522,8 +522,6 @@ const EventDetailsSchedulingTab = ({
 													cancelTranslationString="CANCEL"
 													isLast
 												/>
-
-												<div className="btm-spacer" />
 											</>
 										)}
 									</div>

src/components/events/partials/ModalTabsAndPages/NewAccessPage.tsx

@@ -360,8 +360,6 @@ const NewAccessPage = <T extends RequiredFormProps>({
 				}}
 				previousPage={previousPage}
 			/>
-
-			<div className="btm-spacer" />
 		</>
 	);
 };

src/components/events/partials/ModalTabsAndPages/NewProcessingPage.tsx

@@ -133,8 +133,6 @@ const NewProcessingPage = <T extends RequiredFormProps>({
 				nextPage={nextPage}
 				previousPage={() => previous()}
 			/>
-
-			<div className="btm-spacer" />
 		</>
 	);
 };

src/components/events/partials/ModalTabsAndPages/NewSourcePage.tsx

@@ -225,8 +225,6 @@ const NewSourcePage = <T extends RequiredFormProps>({
 				}}
 				previousPage={previousPage}
 			/>
-
-			<div className="btm-spacer" />
 		</>
 	);
 };

src/components/events/partials/ModalTabsAndPages/SeriesDetailsThemeTab.tsx

@@ -96,8 +96,6 @@ const SeriesDetailsThemeTab = ({
 												cancelTranslationString="CANCEL"
 												isLast
 											/>
-
-											<div className="btm-spacer" />
 										</>
 									)}
 								</div>

src/components/events/partials/ModalTabsAndPages/StartTaskGeneralPage.tsx

@@ -134,8 +134,6 @@ const StartTaskGeneralPage = <T extends RequiredFormProps>({
 				customValidation={!checkValidityStartTaskEventSelection(formik.values)}
 				isFirst
 			/>
-
-			<div className="btm-spacer" />
 		</>
 	);
 };

src/components/events/partials/ModalTabsAndPages/StartTaskWorkflowPage.tsx

@@ -126,8 +126,6 @@ const StartTaskWorkflowPage = <T extends RequiredFormProps>({
 				}}
 				customValidation={!(formik.values.workflow && formik.isValid)}
 			/>
-
-			<div className="btm-spacer" />
 		</>
 	);
 };

src/components/events/partials/modals/DeleteEventsModal.tsx

@@ -142,8 +142,6 @@ const DeleteEventsModal = ({
 				nextTranslationString="WIZARD.DELETE"
 				previousTranslationString="CANCEL"
 			/>
-
-			<div className="btm-spacer" />
 		</>
 	);
 };

src/components/events/partials/modals/EditMetadataEventsModal.tsx

@@ -295,8 +295,6 @@ const EditMetadataEventsModal = ({
 								cancelTranslationString="CLOSE"
 								isLast
 							/>
-
-							<div className="btm-spacer" />
 						</>
 					)}
 				</Formik>

src/components/users/partials/wizard/AclAccessPage.tsx

@@ -350,8 +350,6 @@ const AclAccessPage = <T extends RequiredFormProps>({
 						}
 						previousPage={previousPage}
 					/>
-
-					<div className="btm-spacer" />
 				</>
 			)}
 		</>

src/styles/components/_components-config.scss

@@ -21,7 +21,6 @@
 
 
 @use "simple-box";
-@use "helper-classes";
 @use "cal";
 @use "ui";
 @use "dropdowns";

src/styles/main.scss

@@ -139,7 +139,7 @@ a {
   top: 30px;
   position: fixed;
   max-height: 90vh;
-  overflow: scroll;
+  overflow: auto;
   input[readonly] {
     border: none;
   }