Fix @mui/styled
#1085
Open
Fix @mui/styled
#1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using it in one place only, and while there are certainly some advantages over dynamic inline styles, we are using those pervasively as well anyway. Plus, we pull in MUI for some stuff, which by default relies on Emotion for that stuff, so if we want those benefits, I would propose that it's at least worth considering to get them through that.
As per https://mui.com/material-ui/getting-started/installation/#default-installation. These were installed as (optional?) transitive (peer?) dependencies, but that can of course change randomly. I've seen this happen while preparing a custom build of this repo. Note that there is also https://mui.com/material-ui/getting-started/installation/#with-styled-components, which is arguably more fitting to this project, because we were already using `styled-components`, but I opted for this solution because it seemed simpler and better supported, and also because our usage of `styled-components` isn't really justified. However, see the previous commit for that.
JulianKniephoff
added
the
type:dependencies
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/1085/2025-01-30_16-11-40/ . |
This comment was marked as resolved.
This comment was marked as resolved.
1 similar comment
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Get rid of
styled-componentsWe were using it in one place only, and while there are certainly some advantages over dynamic inline styles, we are using those pervasively as well anyway. Plus, we pull in MUI for some stuff, which by default relies on Emotion for that stuff, so if we want those benefits, I would propose that it's at least worth considering to get them through that.
Explicitly npm install @emotion/react @emotion/styled
As per https://mui.com/material-ui/getting-started/installation/#default-installation.
These were installed as (optional?) transitive (peer?) dependencies, but that can of course change randomly. I've seen this happen while preparing a custom build of this repo.
Note that there is also https://mui.com/material-ui/getting-started/installation/#with-styled-components, which is arguably more fitting to this project, because we were already using
styled-components, but I opted for this solution because it seemed simpler and better supported, and also because our usage ofstyled-componentsisn't really justified. However, see the previous commit for that.