Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bourbon #1107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove bourbon #1107

wants to merge 1 commit into from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Feb 4, 2025

bourbon is no longer maintained (see https://github.com/thoughtbot/bourbon). Furthermore, bourbon is using deprecated SASS that will cause issues sooner rather then later. Therefore this patch removes bourbon entirely and replaces it with native CSS.

Fixes #1040.

How to test this.

Can be tested as usual. Look for any stylistic changes, particularly concerning any borders and notifications.

bourbon is no longer maintained (see https://github.com/thoughtbot/bourbon).
Furthermore, bourbon is using deprecated  SASS that will cause issues
sooner rather then later. Therefore this patch removes
bourbon entirely and replaces it with native CSS.

Fixes opencast#1040.
@Arnei Arnei added type:dependencies Pull requests that update a dependency file type:code-enhancement Internal improvements to the codebase labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1107

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1107

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

This pull request is deployed at test.admin-interface.opencast.org/1107/2025-02-04_14-42-46/ .
It might take a few minutes for it to become available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:code-enhancement Internal improvements to the codebase type:dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dart SASS deprecation warnings
1 participant