Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically deploy with https #76

Open
wants to merge 25 commits into
base: dev
Choose a base branch
from

Conversation

faysal-ishtiaq
Copy link

@faysal-ishtiaq faysal-ishtiaq commented Nov 15, 2022

Closes #64

@cla-bot cla-bot bot added the cla-signed label Nov 15, 2022
@isedwards isedwards changed the title 64 automatically deploy with https Automatically deploy with https Nov 22, 2022
@faysal-ishtiaq
Copy link
Author

faysal-ishtiaq commented Nov 29, 2022

Runs the server on port 80 when $HOST_FQDN and $WEBMASTER_EMAIL are not set. When set, serves on port 443.

Demo: dev4.opencdms.org [instance deleted 25 April 2023]

@isedwards
Copy link
Member

@fabiosato @AbnerBissolli - are you happy for this to be merged to the dev branch? When $HOST_FQDN and $WEBMASTER_EMAIL environment variables are not set the deployment will continue to use HTTP. If the environment variables are set then a LetsEncrypt security certificate will be automatically set up and the application will be served over HTTPS.

@fabiosato
Copy link
Collaborator

@AbnerBissolli do you think it's safe to merge this to dev?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants