Skip to content

Commit

Permalink
fix(containerfile): Env declaration
Browse files Browse the repository at this point in the history
  • Loading branch information
devsjc committed Jan 20, 2025
1 parent 31a1c3c commit 6d13341
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions Containerfile
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,10 @@ COPY cloud_archives /opt/dagster/app
# Run dagster gRPC server on port 4000
EXPOSE 4000

ENV CODE_LOCATION
# Set the code location module to be loaded by the gRPC server
ENV MODULE_NAME=local_archives

# Using CMD rather than ENTRYPOINT allows the command to be overridden in
# run launchers or executors to run other commands using this image
CMD ["dagster", "api", "grpc", "-h", "0.0.0.0", "-p", "4000", "-m", ${CODE_LOCATION}]
CMD ["dagster", "api", "grpc", "-h", "0.0.0.0", "-p", "4000", "-m", ${MODULE_NAME:-local_archives}]

Check warning on line 33 in Containerfile

View workflow job for this annotation

GitHub Actions / build-container

JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals

JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/

0 comments on commit 6d13341

Please sign in to comment.