Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICON module to sources #61

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Add ICON module to sources #61

merged 6 commits into from
Oct 27, 2023

Conversation

devsjc
Copy link
Collaborator

@devsjc devsjc commented Oct 25, 2023

Adds a new driving actor which implements DWD's ICON model from their Opendata API.

Overview:

  • New folder src/nwp_consumer/internal/inputs/icon containing all the API-specific code and unit tests
  • New config ICONConfig in src/nwp_consumer/internal/config/env.py
  • Updated entrypoint to add icon option to cli insrc/nwp_consumer/cmd/main.py
  • Integration tests in src/test_integration now include ICON-specific tests

@devsjc devsjc requested a review from peterdudfield October 26, 2023 08:54
Copy link
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@devsjc devsjc merged commit a7bd351 into main Oct 27, 2023
10 checks passed
@devsjc devsjc deleted the icon branch October 27, 2023 09:17
@devsjc devsjc mentioned this pull request Oct 27, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants