Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pulling all data from Icon via env var #67

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

devsjc
Copy link
Collaborator

@devsjc devsjc commented Dec 4, 2023

Normally the NWP consumer conforms the data sources it pulls from to have matching sets of parameters with consistent naming. However, it is desired that it can be used to pull the entire database of icon files, regardless of whether they are part of the usual subset of variables. This PR enables such functionality.

@devsjc devsjc requested a review from jacobbieker December 4, 2023 16:03
Copy link
Member

@jacobbieker jacobbieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@devsjc devsjc merged commit bf45071 into main Dec 4, 2023
10 checks passed
@devsjc devsjc deleted the icon-all-params branch December 4, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants