-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Canadian Meterological Center Model Support #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done a great job of working out the order of things in the consumer Jacob! This looks grand. The only things missing for a 100% addition of a new source is the following:
- Update main so that the new source is an option
- "Basic" parameter set option in the client
- Integration test on the new source using the basic parameter set
- Passing unit test suite
Also just to check - it seems like this source doesn't need any auth, is that right?
But you've nailed the pattern, I hope it wasn't too painful to get your head around!
Pull Request
Description
This adds support for the GDPS model from CMC, and partly GEPS model support as well.
Relates to #12
How Has This Been Tested?
Unit tests
Checklist: