Tail pointer is not needed #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the output of the python code to be directly compared to what link-parser is printing. It also allows the python unit tests to pass, after the changes to be made in the next commit. Basically, the spell-check test failed, because the desired spell correction never showed up in the smaller sample. Because !spell=99 was set and !max-linkages=100 and so random sampling kicked in.
It is not needed, it makes no difference, it uses space, and it makes the code more complicated.
|
@ampli I am not going to merge this, until you say I should. I don't want to clobber your other pending pull reqs. Let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not needed, it makes no difference, it uses space, and it makes the code more complicated.