Fix very old max cost bug #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes greps simpler.
Dennis had it right. See issue opencog#1449 This improves parsing of real sentences, without causing damage elsewhere.
|
See also #783 |
|
I merged this, but the next pull req will delete it entirely. |
linas
added a commit
to linas/link-grammar
that referenced
this pull request
Feb 25, 2023
It was confusing, broken, and prevented good parses from happening. See opencog#1450 opencog#1449 and opencog#783 and opencog#1453
linas
added a commit
to linas/link-grammar
that referenced
this pull request
Feb 25, 2023
The pull req opencog#1456 broke the existing russian dict. This fixes it. Seems that a cost cutoff of 3.1 is too low, as it rejects many good linkages that come from [[FOO]] & [[BAR]] disjuncts. a cutoff of 4.1 allows these, while rejecting the cost-6 linkages that ruin corpus-basic. As of now, I get 45 errors in ru/corpus-basic.batch which is two less than the 47 that I got, before merging opencog#1450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of cost-max was not to compute the total cost of an expression, but to determine which expressions had single connectors that exceeded a threshold. This allows disjuncts which high-cost individual connectors to be rejected, without otherwise altering parse ranking.
See #1449 for details.