ECMP Member Capability and Configuration #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shri-khare
approved these changes
Mar 28, 2022
shri-khare
approved these changes
Mar 28, 2022
kcudnik
approved these changes
Mar 30, 2022
|
@rck-innovium , @marian-pritsak , please help to approve |
rck-innovium
approved these changes
Mar 31, 2022
wo new Switch attributes are introduced. Read Only: SAI_SWITCH_ATTR_MAX_ECMP_MEMBER_COUNT This attribute is queried during switch init to find out device specific max number of ecmp members supported. CREATE_AND_SET (read/write): SAI_SWITCH_ATTR_ECMP_MEMBER_COUNT This attribute is set based on the query for MAX_ECMP_MEMBER_COUNT and can be changed dynamically. If the SAI adapter doesn't support dynamic change of this attribute based on certain conditions like if ECMP groups are already configured then MUST return error. Expected behavior when SAI_SWITCH_ATTR_ECMP_MEMBER_COUNT is set to a value < SAI_SWITCH_ATTR_MAX_ECMP_MEMBER_COUNT? SAI adapter should allocate the ECMP member count as specified by SAI_SWITCH_ATTR_ECMP_MEMBER_COUNT. This can be changed dynamically; SAI adapter may return OK or ERROR based on if HW supports dynamic change of ECMP member count or not. Decreasing of ecmp member count MUST always return ERROR. Increasing of ecmp member can be supported by newer generation of HW and return OK if supported. Typical Workflow: Switch object create Switch get SAI_SWITCH_ATTR_MAX_ECMP_MEMBER_COUNT: say SAI adapter returns 2k Switch set SAI_SWITCH_ATTR_ECMP_MEMBER_COUNT If step 3 is invoked after the system is fully configured and forwarding traffic SAI adapter MAY return error if HW is not capable of dynamically adjusting the ECMP group size Can you please clarify what is the expected hardware behavior when SAI_SWITCH_ATTR_ECMP_MEMBER_COUNT is set to a value < SAI_SWITCH_ATTR_MAX_ECMP_MEMBER_COUNT Signed-off-by: Jai Kumar <[email protected]>
Signed-off-by: Jai Kumar <[email protected]>
Signed-off-by: Jai Kumar <[email protected]>
marian-pritsak
approved these changes
Apr 4, 2022
rlhui
pushed a commit
that referenced
this pull request
Apr 5, 2022
* Ecmp Member Count wo new Switch attributes are introduced. Read Only: SAI_SWITCH_ATTR_MAX_ECMP_MEMBER_COUNT This attribute is queried during switch init to find out device specific max number of ecmp members supported. CREATE_AND_SET (read/write): SAI_SWITCH_ATTR_ECMP_MEMBER_COUNT This attribute is set based on the query for MAX_ECMP_MEMBER_COUNT and can be changed dynamically. If the SAI adapter doesn't support dynamic change of this attribute based on certain conditions like if ECMP groups are already configured then MUST return error. Expected behavior when SAI_SWITCH_ATTR_ECMP_MEMBER_COUNT is set to a value < SAI_SWITCH_ATTR_MAX_ECMP_MEMBER_COUNT? SAI adapter should allocate the ECMP member count as specified by SAI_SWITCH_ATTR_ECMP_MEMBER_COUNT. This can be changed dynamically; SAI adapter may return OK or ERROR based on if HW supports dynamic change of ECMP member count or not. Decreasing of ecmp member count MUST always return ERROR. Increasing of ecmp member can be supported by newer generation of HW and return OK if supported. Typical Workflow: Switch object create Switch get SAI_SWITCH_ATTR_MAX_ECMP_MEMBER_COUNT: say SAI adapter returns 2k Switch set SAI_SWITCH_ATTR_ECMP_MEMBER_COUNT If step 3 is invoked after the system is fully configured and forwarding traffic SAI adapter MAY return error if HW is not capable of dynamically adjusting the ECMP group size Can you please clarify what is the expected hardware behavior when SAI_SWITCH_ATTR_ECMP_MEMBER_COUNT is set to a value < SAI_SWITCH_ATTR_MAX_ECMP_MEMBER_COUNT * Max ECMP Member Capability/Configuration Signed-off-by: Jai Kumar <[email protected]>
rlhui
added a commit
that referenced
this pull request
Apr 7, 2022
This reverts commit 5e32f5c. Signed-off-by: Rita Hui [email protected]
rlhui
pushed a commit
that referenced
this pull request
Apr 8, 2022
* Ecmp Member Count wo new Switch attributes are introduced. Read Only: SAI_SWITCH_ATTR_MAX_ECMP_MEMBER_COUNT This attribute is queried during switch init to find out device specific max number of ecmp members supported. CREATE_AND_SET (read/write): SAI_SWITCH_ATTR_ECMP_MEMBER_COUNT This attribute is set based on the query for MAX_ECMP_MEMBER_COUNT and can be changed dynamically. If the SAI adapter doesn't support dynamic change of this attribute based on certain conditions like if ECMP groups are already configured then MUST return error. Expected behavior when SAI_SWITCH_ATTR_ECMP_MEMBER_COUNT is set to a value < SAI_SWITCH_ATTR_MAX_ECMP_MEMBER_COUNT? SAI adapter should allocate the ECMP member count as specified by SAI_SWITCH_ATTR_ECMP_MEMBER_COUNT. This can be changed dynamically; SAI adapter may return OK or ERROR based on if HW supports dynamic change of ECMP member count or not. Decreasing of ecmp member count MUST always return ERROR. Increasing of ecmp member can be supported by newer generation of HW and return OK if supported. Typical Workflow: Switch object create Switch get SAI_SWITCH_ATTR_MAX_ECMP_MEMBER_COUNT: say SAI adapter returns 2k Switch set SAI_SWITCH_ATTR_ECMP_MEMBER_COUNT If step 3 is invoked after the system is fully configured and forwarding traffic SAI adapter MAY return error if HW is not capable of dynamically adjusting the ECMP group size Can you please clarify what is the expected hardware behavior when SAI_SWITCH_ATTR_ECMP_MEMBER_COUNT is set to a value < SAI_SWITCH_ATTR_MAX_ECMP_MEMBER_COUNT * Max ECMP Member Capability/Configuration Signed-off-by: Jai Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new Switch attributes are introduced.
Read Only:
SAI_SWITCH_ATTR_MAX_ECMP_MEMBER_COUNT
This attribute is queried during switch init to find out device specific max number of ecmp members supported.
CREATE_AND_SET (read/write):
SAI_SWITCH_ATTR_ECMP_MEMBER_COUNT
This attribute is set based on the query for MAX_ECMP_MEMBER_COUNT and can be changed dynamically.
If the SAI adapter doesn't support dynamic change of this attribute based on certain conditions like if ECMP groups are already configured then MUST return error.
For details see the md file