-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SIGABRT to KillProcessRequest_Signal, allow gNOI to generate coredumps #105
Conversation
Pull Request Test Coverage Report for Build 4236638936
💛 - Coveralls |
@marcushines @aredmon8551 We also need bump the service version (and regen the protos?) |
Please fix lint as well as generate protos I don't know that you have to bump as this is not breaking |
@marcushines shouldn't new functionality (like supporting a new signal) require a bump in the minor version of a semver-styled version string? I.e. in our product documentation we aim to provide a service version which we support, i.e. I think the version should be bumped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcushines here is a suggestion set for fixing gofmt complaints. Although the question remains what protoc-gen code made it non-compliant? Looks weird
I had to manually pull down the referenced projects in the compile.sh script to my $GOPATH because |
Updated based on new proto generated files
Updated based on new proto generated files
All currently defined signals only have an action of terminate, none generate a core. Proposing addition of SIGABRT to support core generation:
https://man7.org/linux/man-pages/man7/signal.7.html