Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify how os.Verify reports UNAVAILABLE #113

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Clarify how os.Verify reports UNAVAILABLE #113

merged 3 commits into from
Feb 7, 2023

Conversation

liulk
Copy link
Contributor

@liulk liulk commented Jan 24, 2023

No description provided.

@coveralls
Copy link

coveralls commented Jan 24, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4000719962

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%
Totals Coverage Status
Change from base Build 3914747371: 0.0%
Covered Lines: 0
Relevant Lines: 0
💛 - Coveralls

hellt
hellt reviewed Jan 24, 2023
View reviewed changes
os/os.proto Show resolved Hide resolved
@samribeiro samribeiro self-assigned this Jan 24, 2023
@dplore
Copy link
Member

dplore commented Jan 25, 2023

Will hold this open for 2 weeks for feedback until Feb 7, 2023.

@samribeiro
Copy link
Member

LGTM

@samribeiro samribeiro mentioned this pull request Feb 1, 2023
Merged
@dplore
Copy link
Member

dplore commented Feb 7, 2023

/gcbrun

@dplore dplore merged commit 5083284 into openconfig:main Feb 7, 2023
@liulk liulk deleted the patch-1 branch February 8, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellt hellt hellt left review comments

@dplore dplore dplore approved these changes

Assignees

@samribeiro samribeiro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liulk @coveralls @dplore @samribeiro @hellt