system: add icmp_ext_data field to TracerouteResponse #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4419455849
💛 - Coveralls |
In order to get the MPLS key/value pairs, traceroute must run with the '-e' flag. However, this flag makes traceroute include all ICMP extensions, and only the MPLS is available in a parsed format. For other ICMP extensions, they will be returned in a format "CLASS/TYPE: followed by a hexadecimal dump" as per the traceroute man page. This change introduces a way to return stream this data back to the client.
marcushines
force-pushed
the
system-traceroute-icmp-ext
branch
from
7b2e016 to
705df8f
Compare
(icmpExtData -> IcmpExtData to appease linter)
marcushines
force-pushed
the
system-traceroute-icmp-ext
branch
from
705df8f to
6f5fa51
Compare
marcushines
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get the MPLS key/value pairs, traceroute must run with the '-e' flag.
However, this flag makes traceroute include all ICMP extensions, and only the MPLS is available in a parsed format. For other ICMP extensions, they will be returned in a format "CLASS/TYPE: followed by a hexadecimal dump" as per the traceroute man page.
This change introduces a way to return stream this data back to the client.