Added VRF option to Ping and Traceroute requests #134
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@robshakir @marcushines Please review |
|
@robshakir please, can you approve the workflows and maybe merge the changes too? |
|
LGTM, apologies -- can you update the minor revision to indicate that we made a change here, and then this is good to merge. |
system/system.proto
Outdated
| @@ -29,7 +29,7 @@ import "types/types.proto"; | |||
|
|
|||
| option go_package = "github.com/openconfig/gnoi/system"; | |||
|
|
|||
| option (types.gnoi_version) = "1.1.2"; | |||
| option (types.gnoi_version) = "1.1.3"; | |||
There was a problem hiding this comment.
Sorry, this needs to be 1.2.0 based on adding fields.
Thanks -- r.
There was a problem hiding this comment.
Fixed it. Thanks.
|
Thanks for the review. Please merge the changes when you get a chance. |
This will allow a client to specify the vrf in which the ping and traceroute has to be run for a given destination.