Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to return reboot result and failure information in RebootStatusResponse message #138

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

akarshgupta25
Copy link
Contributor

@akarshgupta25 akarshgupta25 commented Oct 26, 2023

Add the ability to return reboot result and failure information in RebootStatusResponse message. This includes adding failure information message along with whether the failure is fatal and thus the server is unrecoverable.

@akarshgupta25 akarshgupta25 changed the title Add the ability to return reboot result and failure information in Re… Add the ability to return reboot result and failure information in RebootStatusResponse message Oct 26, 2023
Copy link
Contributor

@marcushines marcushines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest
...
RebootMethod method = 6;
RebootStatus status = 7;
}

message RebootStatus {
enum Status {
STATUS_UNKNOWN = 0;
STATUS_SUCCESS = 1;
STATUS_RETRIABLE_FAILURE = 2;
STATUS_FAILURE = 3;
}
Status status = 1;
string message = 2;
}

@akarshgupta25
Copy link
Contributor Author

I would suggest ... RebootMethod method = 6; RebootStatus status = 7; }

message RebootStatus { enum Status { STATUS_UNKNOWN = 0; STATUS_SUCCESS = 1; STATUS_RETRIABLE_FAILURE = 2; STATUS_FAILURE = 3; } Status status = 1; string message = 2; }

Done. Thanks for the suggestion.

@marcushines marcushines self-assigned this Oct 27, 2023
@marcushines marcushines merged commit 97f5628 into openconfig:main Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants