gNOI Factory Reset - service for factory resetting a Target

[samribeiro]

No description provided.

[ejbrever]

I think the Reboot RPC already supports this (although in a bit more rudimentary way):
https://github.com/openconfig/gnoi/blob/master/system/system.proto#L127

Would it make sense to enhance that RPC instead?

[samribeiro]

@ejbrever I agree with coalescing, however I am reluctant about using the System service at all. In this use case for instance, it is inconvenient to ask that the Reboot RPC in System service be implemented, but no other RPC. That is at the moment our only requirement. It is hard to state requirements when a Service is too overarching, I believe we should aim for slimmer micro-services. Given this, how about extruding the Reboot RPCs from System and augmenting the Reset service?

[robshakir]

@ejbrever -- did you have concerns with this service? I tend to agree with Sam that having this be an explicit RPC seems to make sense.

[ejbrever]

I'm generally good with this, but two thoughts:

1. Should we consider messaging in the Reboot RPC? I guess I am wondering how best to discuss with vendors when they ask why there are two ways to do something. Perhaps in the Reboot RPC we could describe that the preferred RPC for factory reset is over here and the one in system is deprecated?

2. "Reset" has a lot of connotations for networking gear (reset counters, reset/reboot are often used interchangeably). A previous comment mentioned the intention is to have an service that is very small so vendors can just implement the services entirely. If that is the case, do we want to scope what is in "Reset"? Perhaps this should just be called "FactoryReset" if we really want to put a tight scope around this? I could imagine tweaking the names then so instead of the current Reset.Factory(), this becomes FactoryReset.Initiate().

[samribeiro]

Thank you @ejbrever, I agree with you:

• I have updated the naming as you suggest in 2).
• I have updated the System messaging as you suggest in 1).

[ejbrever]

LGTM, thanks for making the changes!

[samribeiro]

thanks!

[aashaikh]

LGTM -- thanks for the updates and discussion.