Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change "types" target for healthz #174

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

rlucus
Copy link
Contributor

@rlucus rlucus commented Mar 7, 2024

The mixed targets between different go_proto_library in each proto was making it difficult to avoid linker problems.

I ran into this when updating to the newest version of gnoi. Was able to work around by including this patch internally.

+ gbazelisk run --config=remote --collect_code_coverage //gnmi_server:gnmi_server_test_image
DEBUG: /usr/local/google/home/mostlyharmless/.cache/bazel/_bazel_mostlyharmless/355348234978af7cf0929b321268140c/external/io_bazel_rules_go/go/private/actions/link.bzl:59:18: Multiple copies of github.com/openconfig/gnoi/types passed to the linker. Ignoring bazel-out/k8-fastbuild-ST-4a519fd6d3e4/bin/external/com_github_openconfig_gnoi/types/types_go_proto.a in favor of bazel-out/k8-fastbuild-ST-4a519fd6d3e4/bin/external/com_github_openconfig_gnoi/types/types.a
INFO: Analyzed target //gnmi_server:gnmi_server_test_image (2 packages loaded, 11 targets configured).
INFO: Found 1 target...
INFO: Docker sandboxing is supported
ERROR: /usr/local/google/home/mostlyharmless/gnmi/sonic-gnmi/gnmi_server/BUILD.bazel:107:8: GoLink gnmi_server/gnmi_server_test_/gnmi_server_test failed: (Exit 1): builder failed: error executing command (from target //gnmi_server:gnmi_server_test) bazel-out/k8-opt-exec-2B5CBBC6-ST-625e526ca8a8/bin/external/go_sdk/builder_reset/builder '-param=bazel-out/k8-fastbuild-ST-4a519fd6d3e4/bin/gnmi_server/gnmi_server_test_/gnmi_server_test-0.params' -- ... (remaining 11 arguments skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
link: package conflict error: github.com/openconfig/gnoi/healthz: package imports github.com/openconfig/gnoi/types
          was compiled with: @com_github_openconfig_gnoi//types:types_go_proto
        but was linked with: @com_github_openconfig_gnoi//types:types
See https://github.com/bazelbuild/rules_go/issues/1877.
Target //gnmi_server:gnmi_server_test_image failed to build

the mixed targets between different go_proto_library in each proto
was making it difficult to avoid linker problems
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8184844745

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 1.205%

Totals Coverage Status
Change from base Build 8161008700: 0.0%
Covered Lines: 166
Relevant Lines: 13780

💛 - Coveralls

@marcushines marcushines merged commit fe1ddb7 into openconfig:main Mar 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants