File #2
Merged
File #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update build files Update gnoi.Path to compliant with gnmi.Path Update simple test to use new path
…iles Update gnoi.Path to compliant with gnmi.Path Update simple test to use new path
update unit tests to pass
robshakir
approved these changes
Aug 17, 2017
| // Path encodes a data tree path as a series of repeated strings, with | ||
| // each element of the path representing a data tree node name and the | ||
| // associated attributes. | ||
| // Reference: gNMI Specification Section 2.2.2. | ||
| message Path { |
There was a problem hiding this comment.
Is there a reason not to have a dependency between gNOI and gNMI here? Should we move to a common Path definition?
There was a problem hiding this comment.
yes we should but i didn't want to block on that as it is a simple change once we figure out what that means
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update system set package to use streaming rpc
Update build files
Update gnoi.Path to compliant with gnmi.Path
Update simple test to use new path