Suggest order in gNOI cert ca_certificates #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // To improve performance in the Target, certificates can be ordered. | ||
| // Groups of chained certificates should be last, where within, the root | ||
| // certificate is the last one. E.g.: | ||
| // CertA, CertB, CertB-Root, CertC, CertC-Intermediate, CertC-Root |
There was a problem hiding this comment.
Sam, looks good. Please note there could also be CA-Cert for target certificate in the bundle.
There was a problem hiding this comment.
Thanks Reshad.
Indeed, I have created another PR to cover that under the simplified security model document.
robshakir
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set expectations in the order that CA certificates should have. This helps with improving performance in the Target when building chained relationships between certificates. This is merely suggested. Certificates can still be provided out of order.