Added the 'no_reboot` flag to the ActivateRequest message. #51
Conversation
If this flag is set to 'False' then the Target will configure itself to boot next time with the requested version of the OS but will _not_ restart immediatelly.
os/os.proto
Outdated
| // If set to 'False' a separate action to reboot the Target and start using | ||
| // the activated OS version is required. This action CAN be executing | ||
| // the gNOI.system.Reboot() RPC. | ||
| bool activate_and_reboot = 3; |
There was a problem hiding this comment.
The inverse logic should be used here in order to keep the same behaviour with backward compatibility. Something like "no_reboot" or "activate_only" (proto3 defaults boolean to false when omitted). Where by default the Activate request will activate and reboot the target, unless this flag is set in which only activation will happen, but no reboot. This allows previous and actual versioned client and target implementations to coexist without a fundamental behaviour change of the RPC like it is being proposed here.
There was a problem hiding this comment.
Keeping backward compatibility sounds like good idea ;-) Done.
os/os.proto
Outdated
| @@ -7,7 +7,7 @@ import "github.com/openconfig/gnoi/types/types.proto"; | |||
|
|
|||
| option go_package = "github.com/openconfig/gnoi/os"; | |||
|
|
|||
| option (types.gnoi_version) = "0.1.0"; | |||
| option (types.gnoi_version) = "0.2.0"; | |||
There was a problem hiding this comment.
assuming the suggestion below, I am thinking this would be a micro bump and opposed to minor.
samribeiro
changed the title
|
Probably worth regenerating the go code for this proto. |
|
Thx! The second commit already includes re-generated Go files. |
If this flag is set to 'False' then the Target will configure itself
to boot next time with the requested version of the OS but will not
restart immediatelly.