Fix references in gNOI protos; cleanup. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove references to the openconfig/reference repo for gNOI types import in both protobufs and the Bazel files. * Regenerate protobufs using protoc v3.5.1.
aashaikh
approved these changes
May 24, 2018
| "github.com/openconfig/gnoi" | ||
| gbgp "github.com/openconfig/gnoi/bgp" | ||
| "github.com/golang/protobuf/proto" | ||
| gpb "github.com/openconfig/gnoi" |
There was a problem hiding this comment.
curious -- why do you need to have a label fo this instead of just using gnoi ?
There was a problem hiding this comment.
This is a style-guide rule - we generally always name things pb at the end to make it clear that they were generated by a protobuf. In packages that require only one proto, you might see it aliased to just pb.
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL fixes references to the openconfig/reference repo in the gNOI protobufs; regenerates the set of protos and performs some misc cleanup (add licensing to the
testGo files; ensure that there is a package file for the tests; add acompile_protos.shscript).