SetPackage support for remote downloads #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Let’s ping @samribeiro on this. @aashaikh is OOO this week. |
robshakir
approved these changes
Apr 12, 2018
samribeiro
reviewed
Apr 13, 2018
system/system.proto
Outdated
| string path = 1; | ||
|
|
||
| enum DownloadType { | ||
| DL_UNKNOWN = 0; |
There was a problem hiding this comment.
I see that RemoteDownload is only used as part of Request and never a Response. In what situation would you use a DL_UNKNOWN value? Perhaps better to just use SFTP as default?
samribeiro
approved these changes
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aashaikh @robshakir @samribeiro Can you please review?