Clarify ping RPC expected behavior #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2586440683
💛 - Coveralls |
|
Since there is no option in the |
|
A flood ping is specified by setting "interval" to -1. |
|
my bad @bstoll |
marcushines
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into a test to verify ping behavior, I became unsure of what is expected in the PingResponse stream. It looks like it would be valid to return individual packets OR summary statistics OR both the individual packets and the summary.
This change is to clarify that summary statistics are always expected, and individual packet metrics should be returned (ie, it's probably not reasonable for a flood request).