os: add package_size to TransferRequest #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow the target to know whether an OS package is going to exceed the maximum possible size before the client starts streaming any bytes to the target. Currently, if the client was to transfer a larger-than-allowed OS package, the target would not be able to detect this until midway through the transfer_content stream.
Pull Request Test Coverage Report for Build 2718230154
💛 - Coveralls |
hellt
reviewed
Jul 20, 2022
Version incremented following the addition of the package_size field to the TransferRequest type
samribeiro
requested changes
Jul 20, 2022
Closed
Closed
marcushines
approved these changes
Oct 6, 2022
samribeiro
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the target to know whether an OS package is
going to exceed the maximum possible size before the
client starts streaming any bytes to the target.
Currently, if the client was to transfer a larger-than-allowed
OS package, the target would not be able to detect this until
midway through the transfer_content stream.