-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WiFi models to support 6 GHz operation. #607
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
deecortes
commented
Mar 25, 2022
Compatibility Report for commit 97794b6: |
mike-albano
reviewed
Mar 30, 2022
mike-albano
reviewed
Apr 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of review done. I think there may be some leafs around the models which need to have their descriptions updated, due to 6GHz not being around when they were first written.
rachitsri
reviewed
Apr 8, 2022
* (M) release/models/wifi/openconfig-ap-manager.yang - Added deployment types and power sources. * (M) release/models/wifi/openconfig-wifi-mac.yang - Added ssid basic/supported data rates, opmode - Changed server-group requirements for new opmodes - Added mfp support * (M) release/models/wifi/openconfig-wifi-phy.yang - Added new channels and neighbor-list-state opmodes. * (M) release/models/wifi/openconfig-wifi-types - Added new channels, operating frequencies and operating capabilities.
* (M) release/models/wifi/openconfig-wifi-types.yang - Consolidated channels for all frequencies. * (M) release/models/wifi/openconfig-wifi-phy.yang - Removed supported-channels-6ghz due to channel consolidation (above). * (M) release/models/wifi/openconfig-ap-manager.yang - Updated power-sources for 802.3bt with Types 3 and 4.
- Removed deployment type as implementation of 6 GHz APs in outdoor environments is still pending. * (M) release/models/wifi/openconfig-wifi-mac.yang - Updated leaf descriptions to include 6 GHz where appropriate. - Added WPA3_ENTERPRISE_192_BIT enum under opmode leaf. - Updated server-group and mfp leaves with WPA3_ENTERPRISE_192_BIT opmode option. - Added wpa3-psk leaf. * (M) release/models/wifi/openconfig-wifi-phy.yang - Updated neighbor-list-state opmodes with WPA3. * (M) release/models/wifi/openconfig-wifi-types - Renamed new 6GHz-related identities for consistency.
c0dc6e3
to
7ef3726
Compare
* (M) release/models/wifi/openconfig-wifi-types - Updated description of 6GHz-related frequency types.
dpp85
reviewed
Apr 28, 2022
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.