Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constants for "index.json" and "blobs" alongside "oci-layout" as parts of the layout specification #1071

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Add constants for "index.json" and "blobs" alongside "oci-layout" as parts of the layout specification #1071

merged 1 commit into from
Jun 23, 2023

Conversation

sparr
Copy link
Contributor

@sparr sparr commented Jun 2, 2023

The layout spec requires three named files/directories. The oci-layout file name is already exposed as a constant from this package. This PR adds exported constants for index.json and blobs.

Closes #1069

@sparr sparr mentioned this pull request Jun 2, 2023
Merged
@sparr sparr force-pushed the path_constants branch from d2c99ee to 9c0eb64 Compare June 2, 2023 18:21
sudo-bmitch
sudo-bmitch requested changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@sudo-bmitch sudo-bmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comment nits. While we're here, I think we should also fix line 18. My attempt would look like:

// ImageLayoutFile is the file name containing ImageLayout in an OCI Image Layout

specs-go/v1/layout.go Outdated Show resolved Hide resolved
specs-go/v1/layout.go Outdated Show resolved Hide resolved
@sparr
Add constants for "index.json" and "blobs"
73f386c 
alongside "oci-layout" as parts of the layout specification

Signed-off-by: Clarence "Sparr" Risher <[email protected]>
@sparr sparr force-pushed the path_constants branch from 9c0eb64 to 73f386c Compare June 2, 2023 19:02
sudo-bmitch
sudo-bmitch approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@sudo-bmitch sudo-bmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TerryHowe
TerryHowe approved these changes Jun 3, 2023
View reviewed changes
Copy link

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

although obviously not a maintainer

@tianon
Copy link
Member

tianon commented Jun 23, 2023

(I don't think I personally plan to use these in the tools I've written that currently hard-code these values, but I do think adding them increases the consistency of the constants we provide ❤️)

@tianon tianon merged commit b5ec432 into opencontainers:main Jun 23, 2023
@sparr sparr deleted the path_constants branch June 23, 2023 03:38
@sparr sparr mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudo-bmitch sudo-bmitch sudo-bmitch approved these changes

@tianon tianon tianon approved these changes

@TerryHowe TerryHowe TerryHowe approved these changes

@jonjohnsonjr jonjohnsonjr Awaiting requested review from jonjohnsonjr jonjohnsonjr is a code owner

@jonboulle jonboulle Awaiting requested review from jonboulle

@stevvooe stevvooe Awaiting requested review from stevvooe stevvooe is a code owner

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@vbatts vbatts Awaiting requested review from vbatts

@cyphar cyphar Awaiting requested review from cyphar cyphar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export constants for "blobs" and "index.json"
4 participants
@sparr @tianon @TerryHowe @sudo-bmitch