image: error out on duplicate tar entry #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
unrelated network error in Travis, any way to re-start it? |
|
@runcom add whitespace to your commit message with |
|
@caniszczyk could we get maintainers access to Travis to be able to restart builds? |
| @@ -154,6 +155,10 @@ loop: | |||
| } | |||
| } | |||
| path := filepath.Join(dest, hdr.Name) | |||
| if entries[path] { | |||
| return fmt.Errorf("%s has been already processed", path) | |||
There was a problem hiding this comment.
IMHO "duplicate entry for %s" would be better
|
tests now green though |
Signed-off-by: Antonio Murdaca <[email protected]>
|
lgtm |
|
LGTM |
|
Do we want to do any cleanup on unpack errors? Or are we
intentionally leaving the partially-extracted rootfs wherever we were
when we hit the error?
|
|
@wking I have a branch which will take care of what you're saying but I'm buried with other stuff/PRs that are higher priority to me right now. |
|
Can you open an issue to track this refactor of the unpack code? |
|
On Thu, Sep 01, 2016 at 09:51:16AM -0700, Antonio Murdaca wrote:
I've opened #242 to track cleanup on unpack errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should address the code change requested in #196
/cc @philips @stevvooe @vbatts @s-urbaniak
Signed-off-by: Antonio Murdaca [email protected]