[ReadMe] Add Compliance Language #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
reviewed
Nov 1, 2016
| @@ -27,6 +27,9 @@ The keywords "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SH | |||
|
|
|||
| The keywords "unspecified", "undefined", and "implementation-defined" are to be interpreted as described in the [rationale for the C99 standard][c99-unspecified]. | |||
|
|
|||
| An implementation is not compliant if it fails to satisfy one or more of the MUST, REQUIRED, or SHALL requirements. | |||
| An implementation is compliant if it satisfies all the MUST, REQUIRED, and SHALL requirements. | |||
There was a problem hiding this comment.
I still think we want the “for the protocols it implements” wording from runtime-spec and a list of protocols contained within this spec (and it seemed like @philips agreed). But as it stands, 15ebbeb is better than nothing. I'm fine having this land and then filing a follow-up PR with the protocol list.
|
LGTM I agree with making the improvements linked though https://github.com/opencontainers/image-spec/pull/432/files#r85947950 |
This was referenced Nov 18, 2016
Add language parallel to what is in the OCI Runtime. Signed-off-by: Rob Dolin <[email protected]> Signed-off-by: Vincent Batts <[email protected]>
|
updated. PTAL. |
|
lgtm okay |
|
LGTM |
wking
added a commit
to wking/image-spec
that referenced
this pull request
Dec 10, 2016
This landed in 836fb1c ([ReadMe] Add Compliance Language, 2016-10-11, opencontainers#432) but was removed in 27508e2 (Clean-up spec to remove non-spec-ish items, 2016-11-14, opencontainers#458), likely accidentally during a rebase. Signed-off-by: W. Trevor King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add language parallel to what is in the OCI Runtime.
This is a carry of #381, with fixed whitespace.
Signed-off-by: Rob Dolin [email protected]
Signed-off-by: Vincent Batts [email protected]