compatibility_test.go:change manifest to manifestlist #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevvooe
reviewed
Jan 13, 2017
| @@ -110,14 +110,14 @@ func TestBackwardsCompatibilityManifestList(t *testing.T) { | |||
| fail: false, | |||
| }, | |||
| } { | |||
| sum := sha256.Sum256([]byte(tt.manifest)) | |||
| sum := sha256.Sum256([]byte(tt.manifestlist)) | |||
There was a problem hiding this comment.
While we're in here, let's start using the digest package to perform these kinds of operations.
There was a problem hiding this comment.
The digest open is manifeslist, so I think there is nothing wrong with the use of manifestlist here.
There was a problem hiding this comment.
That is not what I said. I meant that if you're in the process of cleaning up, it would be better to use the go-digest package.
I've filed #513 to take care this, so don't worry about it.
|
looks good. please rebase |
|
@stevvooe Are you OK with @q384566678's response? |
|
@RobDolinMS No but I guess we can merge anyways. I've filed #513 to handle the concern. |
Signed-off-by: zhouhao <[email protected]>
zhouhao3
force-pushed
the
compatibility-test
branch
from
4f1a95c to
c9935fb
Compare
|
updated. PTAL |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhouhao [email protected]