schema: Drop self-describing media types from manifest(-list) tests #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have happened with 5fc84e5 (specs-go: clarify mediatypes, 2016-10-20, opencontainers#411). Signed-off-by: W. Trevor King <[email protected]>
Catching up with 5fc84e5 (specs-go: clarify mediatypes, 2016-10-20, opencontainers#411). Signed-off-by: W. Trevor King <[email protected]>
This was referenced Jan 26, 2017
|
Make sure to remove this from manifest.md and manifest-list.md, as well. |
|
On Thu, Jan 26, 2017 at 01:22:35PM -0800, Stephen Day wrote:
Make sure to remove this from manifest.md and manifest-list.md, as
well.
Those were marked reserved by #411 (although I'd asked for them to be
removed [1]). If the current maintainer consensus has changed to be
“they should also be removed”, I'm happy to do that in this PR (just
let me know).
[1]: #411 (comment)
|
The fields have been optional/reserved since 5fc84e5 (specs-go: clarify mediatypes, 2016-10-20, opencontainers#411). Signed-off-by: W. Trevor King <[email protected]>
|
On Thu, Jan 26, 2017 at 01:36:02PM -0800, W. Trevor King wrote:
Thu, Jan 26, 2017 at 01:22:35PM -0800, Stephen Day:
> Make sure to remove this from manifest.md and manifest-list.md, as
> well.
Those were marked reserved by #411 (although I'd asked for them to
be removed [1]). If the current maintainer consensus has changed to
be “they should also be removed”, I'm happy to do that in this PR
(just let me know).
Or did you just mean “remove mediaType from those examples”? That
seems less controversial to me, so I've done it with bc6f0fd →
99e6104. Still let me know if you need anything different about the
mediaType definitions [1].
[1]: https://github.com/opencontainers/image-spec/blame/eee8749ab8dd46b26778f6d97a9d59e60aefe5d0/manifest.md#L23
|
|
LGTM |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch up with #411 (and fixing test errors after rebuilding
schema/fs.go).Ideally we'd be testing “is
schema/fs.gocurrent?” in Travis, and I'm trying to handle that in #530, but it's tricky. We can land these test fixes in the meantime, without blocking on more robust CI.